search

grafana / helm-charts

Apache License 2.0
1.67k stars 2.29k forks source link

Add OCI registry support for all Helm charts #3366

Closed domolitom closed 1 month ago

domolitom commented 1 month ago

Some Helm charts, such as Loki, are not being pushed to an OCI registry because OCI support is missing in the update-helm-repo.yaml workflow, which is used for external releases.

Solution: This PR introduces a step that ensures Helm charts are also pushed to the GitHub Container Registry (GHCR) as part of the release process, providing OCI support for charts that were previously excluded.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

domolitom commented 1 month ago

@Sheikh-Abubaker

narqo commented 1 month ago

Thank you for the PR. The changes look very similar to an earlier PR https://github.com/grafana/helm-charts/pull/3115 (which got slipped from the final reviews). Could you help testing it?

domolitom commented 1 month ago

@narqo that is true. I didn't see the already open PR. Btw the PR https://github.com/grafana/helm-charts/pull/3115 needs to be edited, the workflow needs write permission to packages. I just added it into this PR.