grafana / jsonnet-libs

Grafana Labs' Jsonnet libraries
Other
633 stars 161 forks source link

feat: OracleDB logs expression update #1299

Closed algchoo closed 3 months ago

algchoo commented 3 months ago

Description

The expression for logs required a label called filename with a value that equates to an alert log file path. In k8s this file is not something that is read from. Requiring an arbitrary label with a value to a path that does not exist is potentially confusing.

The solution, alter the expression to accept filename=pathToAlertLogs or log_type="oracledb" and in the k8s plugin snippets for collecting logs, we add log_type="oracledb" and users can just copy/paste the config without potentially becoming confused.

Important note:

The OracleDB container logs are more than just logs from the alert file and there's not a clear way to filter on just the ones we'd get from the alert log.

Changes