feat: Persistent theme settings

grafana / k6-studio

Desktop application for Mac and Windows (Linux coming soon) designed to help you generate k6 test scripts

GNU Affero General Public License v3.0

140 stars 1 forks source link

feat: Persistent theme settings #347

Closed going-confetti closed 2 weeks ago

going-confetti commented 2 weeks ago

Description

How to Test

Try changing the default setting
Close the app
Open it again - the setting should persist

Checklist

[ ] I have performed a self-review of my code.
[ ] I have added tests for my changes.
[ ] I have run linter locally (npm run lint) and all checks pass.
[ ] I have run tests locally (npm test) and all tests pass.
[ ] I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

Related PR(s)/Issue(s)

going-confetti commented 2 weeks ago

Oh man, I loved that switch in activity bar 😞 It removes the friction to test both themes when developing, can we keep it in activity bar additionally to settings? We could also wrap in dev mode condition if there's a reason we don't want to have it there in prod builds.

Let's make it dev-only for now 👍