search

grafana / kindsys

a kind system for schematizing objects
Apache License 2.0
12 stars 0 forks source link

Remove redundant field prefixes from PanelCfg interface #7

Closed sdboyer closed 1 year ago

sdboyer commented 1 year ago

Does what it says on the tin.

Requires a bunch of updates in grafana/grafana and grafana/grok.

Fixes #6

sdboyer commented 1 year ago

@dprokop would love to get your sign-off that this is what you had in mind

@ryantxu any concerns with dropping these prefixes? see https://github.com/grafana/grafana/pull/64723#issuecomment-1481665532

sdboyer commented 1 year ago

we may want to have the Grafana's PR ready before getting this merged.

Definitely, otherwise it'll be unsafe to update kindsys. Need to coordinate those PRs

@Duologic @malcolmholmes fyi, this will echo directly through to all of our grok codegen.