search

grafana / metrictank

metrics2.0 based, multi-tenant timeseries store for Graphite and friends.
GNU Affero General Public License v3.0
621 stars 105 forks source link

Add support for removeZeroSeries function #2034

Closed carrieedwards closed 2 years ago

carrieedwards commented 2 years ago

This PR adds support for removeZeroSeries in Graphite web, which operates similarly to removeEmptySeries, but instead checks data points in the series for values equal to 0, instead of values equal to math.NaN().

shanson7 commented 2 years ago

I don't see this function in graphite docs. Metrictank functions should also be in graphite.

ywwg commented 2 years ago

This function is in go-graphite, which a customer is using so we need to support this function.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Jxlam-pdx commented 2 years ago

@replay, this PR is ready to go. @carrieedwards is not authorized to merge it. Can you grant her access? thanks!

replay commented 2 years ago

The PR should also update the table of functions here: https://github.com/grafana/metrictank/blob/master/docs/graphite.md#processing-functions

As Sean pointed out, this function doesn't exist in Graphite. How would you feel about also contributing it to Graphite after merging this PR, for parity?

carrieedwards commented 2 years ago

I can contribute the same to Graphite as well.

replay commented 2 years ago

I can contribute the same to Graphite as well.

that would be great, thank you