grafana / oncall

Developer-friendly incident response with brilliant Slack integration

GNU Affero General Public License v3.0

3.55k stars 294 forks source link

feat: Introduce a new standartized drf errors format #5223

Closed iskhakov closed 4 weeks ago

iskhakov commented 1 month ago

What this PR does

This pull request aims to standardize error handling in the Django Rest Framework by implementing the drf_standardized_errors package. The changes involve:

Adding a new error formatter class that combines the old and new error response formats to maintain compatibility.
Updating multiple API views to raise standardized exceptions instead of returning error responses directly.

Which issue(s) this PR closes

Related to [issue link here]

Checklist

[ ] Unit, integration, and e2e (if applicable) tests updated
[ ] Documentation added (or pr:no public docs PR label added if not required)
[ ] Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will show up in the autogenerated release notes.

iskhakov commented 4 weeks ago

some of the exceptions that are raised outside of drf are not handled by drf-standartized-errors handler, especially in middleware. We need to address that before rolling this pr. Closing the PR for now