grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.96k stars 596 forks source link

Add authentication methods for API access #655

Closed petethepig closed 2 years ago

petethepig commented 2 years ago

Now that we have OAuth support for viewing the data we need to add authentication support for API clients, particularly:

Currently, when set up with OAuth client integrations bypass authentication altogether (/ingest doesn't do authentication), and grafana panel can't access data at all. We need some way of setting some API keys for both.

eh-am commented 2 years ago

For grafana datasource we need to do the following

  1. add the input to support API_KEY https://github.com/pyroscope-io/pyroscope/blob/main/grafana-plugin/datasource/src/ConfigEditor.tsx#L27-L39

  2. update the fetch calls to use that API_KEY as header https://github.com/pyroscope-io/pyroscope/blob/main/grafana-plugin/datasource/src/ConfigEditor.tsx#L27-L39

kolesnikovae commented 2 years ago

Please review the docs and Grafana plugin PRs.

petethepig commented 2 years ago

Released in 0.10.2