search

grafana / redshift-datasource

Apache License 2.0
9 stars 11 forks source link

Update for added context in grafana-aws-sdk #279

Closed njvrzm closed 6 months ago

njvrzm commented 6 months ago

Like the similar PR in the Athena datasource, this PR adds context handling in a number of places to support the changes in the associated grafana-aws-sdk PR.

This also replaces instances of context.TODO() in tests with context.Background(), so that the former remains a useful signal.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

njvrzm commented 6 months ago

Shouldn't GetAsyncDB also be updated to take a context?

Hm - maybe! But not as part of this PR, since it's still being called without context from grafana-aws-sdk. I think we can probably add that if a use for it comes up?