grafana / rollout-operator

Kubernetes Rollout Operator
Apache License 2.0
141 stars 20 forks source link

separate statefulset name and statefulset service name in downscaling #173

Open fitz7 opened 1 month ago

fitz7 commented 1 month ago

I found that the rollout-operator was not calling the right pod endpoint with our mimir installation but was calling mimir-ingester-zone-c-1.mimir-ingester-zone-c.mimir.svc.cluster.local when it should be using the headless service at mimir-ingester-zone-c-1.mimir-ingester-headless.mimir.svc.cluster.local

This led me to issue #125 so checked on our statefulsets and found the serviceName was correctly set to serviceName: mimir-ingester-headless

so I dug around a bit and found that the operator was using the an arg named serviceName in createPrepareDownscaleEndpoints but passing it the statefulset name.

So I've split them to use both the statefulsets name and it's serviceName so that hopefully these requests go to the correct pods

Let me know if this needs changing or if there is another approach that I've missed?

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.