search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

MultiValueVariable: Fixes support for legacy All url value #712

Closed torkelo closed 5 months ago

torkelo commented 5 months ago

Fixes https://github.com/grafana/grafana/issues/87167

A previous fix for this https://github.com/grafana/scenes/pull/656 only added a unit test for the scenario where includeAll and isMulti was false (so not truly multi value). when isMulti is true the URL value is an array and so the comparison that checked for the old legacy ALL URL value did not pass as the urlValue was an array with "All"

📦 Published PR as canary version: 4.13.2--canary.712.8910747975.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes@4.13.2--canary.712.8910747975.0 # or yarn add @grafana/scenes@4.13.2--canary.712.8910747975.0 ```
grafanabot commented 5 months ago

:rocket: PR was released in v4.13.2 :rocket: