search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

SceneQueryRunner: make some fields and methods protected #745

Closed sd2k closed 3 months ago

sd2k commented 4 months ago

PR #587 is quite a large change and introduces more concepts to scenes, so isn't easy to justify merging right now. As a workaround, I'd like to be able to subclass and override some methods of the SceneQueryRunner to implement some similar behaviour in a different library, but I need various fields and methods to be accessible to the subclass, which this PR does by making them protected rather than private.

Note: I can almost just completely copy/paste the class into my own code rather than extending it, but the getQueriesForVariables function looks for all instances of SceneQueryRunner, which my copy/pasted class would not match (unlike a subclass, which should), so I think some ad-hoc variable support would break :(

I'm hoping this is a less controversial change than #587 which will unblock me - let me know what you think!

sd2k commented 3 months ago

Closing, not needed now that #587 has been merged :tada: