search

grafana / tempo

Grafana Tempo is a high volume, minimal dependency distributed tracing backend.
https://grafana.com/oss/tempo/
GNU Affero General Public License v3.0
3.87k stars 503 forks source link

Support Zone Aware Replication cli Flags #3877

Closed KyriosGN0 closed 1 month ago

KyriosGN0 commented 1 month ago

Is your feature request related to a problem? Please describe. in our org we use 3 AZ for mimir and we would like to be able do that with Tempo Describe the solution you'd like Ability to specify an AZ in cli flag like -ingester.availability-zone Describe alternatives you've considered use ENV var (but as we use helm chart its not possible) Additional context

KyriosGN0 commented 1 month ago

@zalegrala @joe-elliott, i've seen we parse the Cli flags here and we use default flags in ring.lifecyclerConfig which already has this cli flag defined here does this mean i just need to export this flag in Tempo cli ? or is there anything else needed ?

joe-elliott commented 1 month ago

That is correct. If you'd like to expose that config option you simply need to add a line in RegisterFlagsAndApplyDefaults