search

grafana / tutorials

A series of tutorials for helping you make the most out of Grafana.
Apache License 2.0
111 stars 29 forks source link

Build a data source plugin tutorial - Step 8 #52

Closed jssm closed 4 years ago

jssm commented 4 years ago

Tutorial link

On step 8, since the variable resolution is defined as a number, a conversion from string is missing on the onResolutionChange method. And the fact that is defined as a "number?" on the types.ts file, it also gives problems when using it on the DataSource.ts file (I just took the ? since a default value of 1000 is given on the FormField of the ConfigEditor if nothing is set).

Is it possible to revise these points? Pretty please :)

Thank you very much and kind regards

marcusolsson commented 4 years ago

Thank you! Looking into this now.

marcusolsson commented 4 years ago

@jssm I've published the fixes. Let me know if you're still experiencing any issues with the tutorials!

jssm commented 4 years ago

Thank you @marcusolsson, it makes much more sense now :)