Desobekify `BrowserContext.grantPermissions` options parsing - Githubissues

grafana / xk6-browser

The browser module adds support for browser automation and end-to-end web testing via the Chrome Devtools Protocol to k6.

https://grafana.com/docs/k6/latest/javascript-api/k6-browser/

GNU Affero General Public License v3.0

344 stars 41 forks source link

Desobekify `BrowserContext.grantPermissions` options parsing #1511

Closed inancgumus closed 3 weeks ago

inancgumus commented 3 weeks ago

What?

Moves BrowserContext.grantPermissions Sobek-option parsing into the mapping layer.

Why?

Turns GrantPermissionsOptions to a value type from a pointer, as this type does not need to be used to be mutated. Using value types is likely to be less racy and more performant.
Moves Sobek transformation to the mapping layer.

Also, see the reasons in #1064.

Checklist

[x] I have performed a self-review of my code
[x] I have added tests for my changes
[x] I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

1270
1510