search

grafeas / voucher

🎟 Voucher creates attestations for Binary Authorization
Apache License 2.0
73 stars 20 forks source link

move source code into v2 directory #27

Closed catherinejones closed 3 years ago

catherinejones commented 3 years ago

This PR should allow us to support v2 modules going forwards. This PR should resolve https://github.com/grafeas/voucher/issues/19!

The instructions here suggest copying these files, however since we've been storing "v2" code in the root of the directory I think that would make things more confusing than moving them. What do y'all think?

ooq commented 3 years ago

IIUC, moving (vs. copying) would mean we cannot update both v1 and v2 versions in the same branch ("main"). But I guess we haven't been using main to update v1 anyway, so this is fine?

catherinejones commented 3 years ago

@ooq if we wanted, we could pull in the source code from the most recent version of v1 into the main branch, but I think that'd cause more problems than it fixed honestly!

rxbchen commented 3 years ago

👋 with this change, would I need to pull in /go/src/github.com/grafeas/voucher/v2 instead?

catherinejones commented 3 years ago

@rxbchen yes, that's correct!