grails / gorm-hibernate5

GORM for Hibernate 5
Apache License 2.0
62 stars 68 forks source link

javax to jakarta, groovy 4, spring framework 6 and spring boot 3 migrations #878

Closed jamesfredley closed 1 month ago

jamesfredley commented 1 month ago

PR so that a 9.0.0-SNAPSHOT can be published and we can continue working on other grails dependencies while we work on the failing tests ignored on this PR. https://github.com/grails/gorm-hibernate5/issues/879

Requires https://github.com/grails/grails-data-mapping/pull/1810 changes and org.grails:grails-datastore-*:9.0.0-SNAPSHOT

Key Changes and Issues:

Groovy-5106 issues:

The interface GormEntity cannot be implemented more than once with different arguments: org.grails.datastore.gorm.GormEntity<grails.gorm.tests.XXX> and org.grails.datastore.gorm.GormEntity<grails.gorm.tests.XXX>

examples-grails-data-service

General error during canonicalization: No signature of method: org.codehaus.groovy.ast.ClassCodeExpressionTransformer.transform() is applicable for argument types: (org.codehaus.groovy.ast.expr.MethodCallExpression) values: [org.codehaus.groovy.ast.expr.MethodCallExpression@776b49b2[object: org.codehaus.groovy.ast.expr.VariableExpression@30b9eadd[variable: response] method: org.codehaus.groovy.ast.expr.ConstantExpression@497570fb[status] arguments: org.codehaus.groovy.ast.expr.ArgumentListExpression@412c995d[org.codehaus.groovy.ast.expr.PropertyExpression@3249a1ce[object: org.codehaus.groovy.ast.expr.ClassExpression@4dd94a58[type: org.springframework.http.HttpStatus] property: org.codehaus.groovy.ast.expr.ConstantExpression@2f4919b0[UNPROCESSABLE_ENTITY]]]]]

https://github.com/grails/gorm-hibernate5/pull/878/files#diff-12879bcb16768df7b12cc0afc7feb7dec6daac16cc78ab20d97a86461a37771f java.lang.IllegalStateException: Either class [example.Customer] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity.

https://github.com/grails/gorm-hibernate5/pull/878/files#diff-b959418ad6dfb5509464cf7b01fe22b84cf1d72f4756299d9382f2f5afded695 java.lang.IllegalStateException: Either class [example.Book] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity. java.lang.IllegalStateException: Either class [example.Book] is not a domain class or GORM has not been initialized correctly or has already been shutdown. Ensure GORM is loaded and configured correctly before calling any methods on a GORM entity.

Additional currently failing tests.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

jamesfredley commented 1 month ago

The failing tests on these changes will require a material effort to resolve, but for now should wait until the Grails 7 apps start.

jamesfredley commented 1 month ago

I have updated this repo to use publishToMavenLocal.