search

grails / grails-core

The Grails Web Application Framework
http://grails.org
Apache License 2.0
2.78k stars 951 forks source link

Fix stop-app in grails cli #13695

Open codeconsole opened 2 hours ago

codeconsole commented 2 hours ago

https://github.com/grails-profiles/base/blob/7.0.x/commands/stop-app.groovy

codeconsole commented 2 hours ago

https://github.com/grails-profiles/base/issues/31

codeconsole commented 1 hour ago

management-agent.jar was removed after java 1.8 and this code should be removed/refactored

https://github.com/grails-profiles/base/blob/6294515794b8ac8ae4eeb6a3da7ff40e5f132bb8/commands/stop-app.groovy#L31

codeconsole commented 1 hour ago

https://github.com/grails-profiles/base/blob/6294515794b8ac8ae4eeb6a3da7ff40e5f132bb8/commands/stop-app.groovy#L76-L98

Perhaps there is a better way to stop the app similar to how quit works https://github.com/grails/grails-core/blob/ab9fdf3921f6a04f355d3b8282b9b29d16b98dab/grails-shell/src/main/groovy/org/grails/cli/GrailsCli.groovy#L665-L672