dfober
commented
6 years ago OpenSSL is not required any more (nor any other library). SHA1 is now part of the src code. The remaining references to OpenSSL should be removed.
Le 19 mars 2018 à 08:23, Jean-Michaël Celerier notifications@github.com a écrit :
Hello,
I noticed that for a "normal" faust build, if I am not mistaken, OpenSSL is only used for that one tiny SHA1 function call here : https://github.com/grame-cncm/faust/blob/1093937dc648fe24b802a7ecb7221b2eaa35d35c/compiler/generator/llvm/machine/llvm_machine_dsp_aux.cpp#L730 https://github.com/grame-cncm/faust/blob/1093937dc648fe24b802a7ecb7221b2eaa35d35c/compiler/generator/llvm/machine/llvm_machine_dsp_aux.cpp#L730 Woul it make sense to replace with a smaller library that only does this without requiring cumbersome (at least on windows!) dependencies, such as : https://github.com/mohaps/TinySHA1 https://github.com/mohaps/TinySHA1 or https://github.com/kazuho/picohash https://github.com/kazuho/picohash ?
I can contribute a patch which uses tinysha1 if you are interested.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/grame-cncm/faust/issues/159, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaTw-CvPwTpf2kDPuOnBLSbHzAZ1riNks5tf1zsgaJpZM4Svsaj.
jcelerier
sletz
Hello,
I noticed that for a "normal" faust build, if I am not mistaken, OpenSSL is only used for that one tiny SHA1 function call here : https://github.com/grame-cncm/faust/blob/1093937dc648fe24b802a7ecb7221b2eaa35d35c/compiler/generator/llvm/machine/llvm_machine_dsp_aux.cpp#L730
Woul it make sense to replace with a smaller library that only does this without requiring cumbersome (at least on windows!) dependencies, such as : https://github.com/mohaps/TinySHA1 or https://github.com/kazuho/picohash ?
I can contribute a patch which uses tinysha1 if you are interested.