search

grammyjs / grammY

The Telegram Bot Framework.
https://grammy.dev
MIT License
2.28k stars 112 forks source link

build: update deno2node, fix docs, add suggestions to sendDice #626

Closed rayz1065 closed 1 month ago

rayz1065 commented 1 month ago

The JSDocs for api.sendDice and ctx.replyWithDice were missing '🎳' so I brought them up to date with the latest changes on https://core.telegram.org/bots/api#senddice. I also added suggestions for the parameter emoji following the style in sendChatAction. It might be reasonable to remove | (string & Record<never, never>) but I didn't want to introduce a breaking change.

I also fixed two JSDocs with an incorrect link to the documentation.

KnorpelSenf commented 1 month ago

Can you fix the formatting?

KnorpelSenf commented 1 month ago

Hang on, it's actually not related to these changes, I'll investigate

KnorpelSenf commented 1 month ago

I guess we can just disable the lint until we support node:http as an adapter on Deno

KnorpelSenf commented 1 month ago

@rayz1065 please consider signing your commits in the future. We usually require this from all contributions, but I made an exception now and merged anyway.

@all-contributors add @rayz1065 for the idea and the code!

allcontributors[bot] commented 1 month ago

@KnorpelSenf

I've put up a pull request to add @rayz1065! :tada: