`Conv1d` isn't made visible

graphcore-research / unit-scaling

A library for unit scaling in PyTorch

Apache License 2.0

105 stars 7 forks source link

Closed EIFY closed 2 months ago

EIFY commented 2 months ago

I just noticed that Conv1d isn't made visible in https://github.com/graphcore-research/unit-scaling/pull/67 So for now one needs to e.g.

from unit_scaling._modules import Conv1d

instead of

import unit_scaling as uu
# (...)
self.conv = uu.Conv1d(...)

like the rest of the public modules.

DouglasOrr commented 2 months ago

Thank you for reporting this! I've prepared a fix, which should be able to go in soon.