search

graphicore / librebarcode

Libre Barcode: barcode fonts for various barcode standards.
https://graphicore.github.io/librebarcode
SIL Open Font License 1.1
429 stars 25 forks source link

List Inconsolata-Regular as a dependency #8

Closed felipesanches closed 6 years ago

felipesanches commented 7 years ago

The build script seems to use Inconsolata-Regular.ttf for the --fontbelow feature in the "Text" variants for rendering text below the barcodes.

There's the issue that the build script assumes Inconsolata is available at this relative directory:

TEXT_BELOW_FONT=`pwd`/../fonts/ofl/inconsolata/Inconsolata-Regular.ttf

And I also wonder whether wouldn't it be good to mention somewhere that the resulting font includes glyphs from Inconsolata-Regular and thus is a derivative of it.

graphicore commented 7 years ago

Updated

List Inconsolata-Regular as a dependency

When I wrote that I wasn't even sure which font should be used as the font below. This was just quick.

There's the issue that the build script assumes Inconsolata is available at this relative directory:

It should probably be an argument to the build script; maybe even optional. But if it is an argument, it's not a real dependency anymore, because it could be any other font as well. Any suggestions?

Also, inconsolata (or anything) could be explicitly part of this repository. Then it would be straight forward to have a hard coded path to it.

whether ... to mention somewhere that the resulting font ... is a derivative of [Inconsolata-Regular]

You know where that would be?

cc @davelab6

davelab6 commented 7 years ago

I agree that

TEXT_BELOW_FONT=`pwd`/../fonts/ofl/inconsolata/Inconsolata-Regular.ttf

is an easy stumbling point; could be good to just copy a version of that font into the repo and refer to its local path

khaledhosny commented 6 years ago

This was fixed in 1477c7c08296123aa6ac803647fd54e5e97aaad0 by copying Inconsolata-Regular.ttf to the repository.