Strict validation of AssemblyScript array length

graphprotocol / graph-node

Graph Node indexes data from blockchains such as Ethereum and serves it over GraphQL

https://thegraph.com

Apache License 2.0

2.92k stars 982 forks source link

Strict validation of AssemblyScript array length #2241

Open leoyvens opened 3 years ago

leoyvens commented 3 years ago

See https://github.com/graphprotocol/graph-node/pull/2140, we know that there are subgraphs in the hosted service that trip this, we should investigate why and fix the root cause. And eventually move to a stricter check.

evaporei commented 3 years ago

Just to clarify things a bit for future use:

Unfortunately we did not record the information of which subgraph caused this issue;
The error was a panic when switching chunks for chunks_exact;
Using chunks might leave unread bytes at the end, which is weird. But we haven't seen any real consequence of this yet.