graphprotocol / graph-node

Graph Node indexes data from blockchains such as Ethereum and serves it over GraphQL
https://thegraph.com
Apache License 2.0
2.9k stars 963 forks source link

[Help] Do non-fatal errors get unfailed? #5159

Open paymog opened 8 months ago

paymog commented 8 months ago

Description

I'm trying to better understand how graph node handles subgraph failures and I learned that graph node automatically unfails subgraphs on initialization and during other aspects of the subgraph lifetime.

Based on this comment and this comment it seems that only fatal errors are unfailed while non-fatal errors persist. Is that correct?

Is there a way to query the database and know if a subgraph will be unfailed at some point in the future or is that managed entirely through in memory?

Ninja edit: it seems that non-fatal errors can get wiped too eg here and here where None is passed to the non_fatal_errors vector - might this be a bug?

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

No response

Some information to help us out

github-actions[bot] commented 1 month ago

Looks like this issue has been open for 6 months with no activity. Is it still relevant? If not, please remember to close it.