search

graphql-python / flask-graphql

Adds GraphQL support to your Flask application.
MIT License
1.32k stars 140 forks source link

Add logger for GraphQL execution exception #7

Closed czchen closed 7 years ago

czchen commented 8 years ago

The current implementation catch all GraphQL execution exception and return as errors in response. However, the detail information of exception like line number, file name, call stack are missing. It would be difficult to debug when not having these information.

I think it could be better to have a new member logger, and when there is an execution exception, it can use logger.exception to log this exception for debugging.

syrusakbary commented 7 years ago

This issue was fixed in https://github.com/graphql-python/graphql-core/issues/41 (commits https://github.com/graphql-python/graphql-core/commit/f2175f5ee081771b9caad2eb32513e88648c0ca1, https://github.com/graphql-python/graphql-core/commit/0143e08b28f8082b3e05e95af59b27336b3cb766).

Closing issue :)