Update context and root executor options

graphql-python / flask-graphql

Adds GraphQL support to your Flask application.

MIT License

1.32k stars 140 forks source link

Update context and root executor options #74

Closed KingDarBoja closed 4 years ago

KingDarBoja commented 4 years ago

📦 Enhancement

Fixes #70 and Fixes #71

[x] Bump graphl-core minimum version to 2.3 (was 2.1).
[x] Provide context_value and root_value to executor options (was context and root).

coveralls commented 4 years ago

Coverage remained the same at 93.548% when pulling ddfe787e272e1dcbbab790bb97e351570488387e on KingDarBoja:enhancement/update-context-root-values into 0137ca1315d811a7e01a1d256e41c74bc1c3fc2c on graphql-python:master.

rzane commented 4 years ago

Would it be possible to publish a new version that includes this change? These warnings are spamming my console 😄

checor commented 4 years ago

An update would be surely appreciate. But I can understand if this isn't a priority or worthy.

silpol commented 4 years ago

any chance to get it included into PyPI-published release? thank you

KingDarBoja commented 4 years ago

These changes are included on latest beta version of graphql-server, checkout https://github.com/graphql-python/graphql-server/blob/master/docs/flask.md