search

graphql / graphql-spec

GraphQL is a query language and execution engine tied to any backend service.
https://spec.graphql.org
14.31k stars 1.13k forks source link

chore: Update cspell.yml #1100

Closed Jason3S closed 5 months ago

Jason3S commented 5 months ago

The current cspell.yml file doesn't parse.

!!! IMPORTANT !!!

Please Read https://github.com/graphql/graphql-spec/blob/master/CONTRIBUTING.md before creating a Pull Request.

linux-foundation-easycla[bot] commented 5 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

netlify[bot] commented 5 months ago

Deploy Preview for graphql-spec-draft ready!

Name Link
Latest commit bd6231ae75570137ecdfda440519a71633b92775
Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/6666ef7bba848e00087f64c0
Deploy Preview https://deploy-preview-1100--graphql-spec-draft.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jason3S commented 5 months ago

Hello @benjie,

Two things:

  1. I noticed that the latest changes to cspell.yml do not parse as correct Yaml. This PR is to address that. This fix includes one of the newer CSpell features to make suggestions on the desired spelling. An alternative fix is to just surround - !implementor and - !implementors with quotes: - '!implementor'.
  2. The version of CSpell is quite old. Is there a reason to stay on v5?
benjie commented 5 months ago

The version of CSpell is quite old. Is there a reason to stay on v5?

Not particularly. No particular need to upgrade either though.