search

graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)
https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql
MIT License
557 stars 71 forks source link

fix: Downgrade graphql config #196

Closed carmenberndt closed 4 years ago

carmenberndt commented 4 years ago

Since commit https://github.com/prisma-labs/vscode-graphql/commit/bb93c44cc856318ce8c113940872bfe7deef1132#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 the CI has been failing silently because of peer dependency issues. Therefore downgrading to 0.12.x for dep graphql .

cc @acao

dep

divyenduz commented 4 years ago

Yikes, silently failing CI. Compiling as tests is a good first step.

divyenduz commented 4 years ago

Note that this is not a breaking change. Since March 12, no extension was published due to CI silently failing. Hopefully, with Rikki's work in https://github.com/prisma-labs/vscode-graphql/issues/181, we will be actually able to support the latest GraphQL versions.

acao commented 4 years ago

good afternoon from across the pond! i was able to resolve all the peer dependency issues in my PR, however I had to remove the prisma graphql config extension to do so. the prisma config extension itself still depends on graphql@2.2 which has outdated peer deps that dont include graphql@15. the insiders release I made last night had no peer dependency issues. we definately need to be using graphql 15 to support some of the features I'm using in that PR.