graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)
https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql
MIT License
557 stars 71 forks source link

feat: provide 'Execute Query' for /* GraphQL */ templates #277

Closed AumyF closed 2 years ago

AumyF commented 3 years ago

It partially fixes #232. (Completions still don't work; we may need to fix graphql-language-service-server.)

image

acao commented 2 years ago

@AumyF awesome! yes correct, I can show you where that lives in the language server, findGraphQLTags.

acao commented 2 years ago

https://github.com/graphql/graphiql/blob/fe5bb0dca326ee307bb6a618536819c0b505f7c9/packages/graphql-language-service-server/src/findGraphQLTags.ts#L71 here is where we specify the template tags - i.e. gql`` , graphql``, gql(), and graphql().

in order to pick up on a comment such as this one or #graphql comment declaration, we will need to add new babel parser visitors

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: c68375a21de3968bd057210a161d4c695602f66c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | vscode-graphql | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

linux-foundation-easycla[bot] commented 2 years ago

CLA Not Signed

acao commented 2 years ago

I'm terribly sorry @AumyF , when rebasing your commit to handle upstream conflicts and add changeset I somehow broke the authorship by accident, and now the CLA bot isn't happy ://. i tried doing `git commit --amend --author="Aumy "