search

graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)
https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql
MIT License
557 stars 71 forks source link

Enable in vue files #307

Closed tobiasdiez closed 2 years ago

tobiasdiez commented 3 years ago

This enables the extension in vue files as well.

Doesn't quite work yet and depends on a proper implementation of the server backend: https://github.com/graphql/graphiql/issues/1678

linux-foundation-easycla[bot] commented 3 years ago

CLA Signed

The committers are authorized under a signed CLA.

acao commented 2 years ago

@tobiasdiez can you sign the CLI? this would be awesome to contribute! I appreciate it!

tobiasdiez commented 2 years ago

I've already signed the CLA for the graphql specs orgs (https://github.com/graphql/graphql-spec/pull/881). But for some reason this is not picked up here, and signing again also doesn't work (afterwards I'm redirected to the above PR).

acao commented 2 years ago

@brianwarner do you know why this bug with the CLA bot is happening?

@tobiasdiez until then, I can create a new PR and give you co-author credit :) would love to get this out in the next release along with language server improvements!

tobiasdiez commented 2 years ago

Sure, feel free to (re)use my changes as you see fit!

brianwarner commented 2 years ago

Hmm, I'm not sure, I see the signature in the system. However, it may be that EasyCLA needs to be manually run. One sec and I'll drop in the magic comment that does it.

brianwarner commented 2 years ago

/easycla

brianwarner commented 2 years ago

That worked!

acao commented 2 years ago

@tobiasdiez ready to merge, thank you for this! I will keep you posted as we find ways to support language features in vue files

zigomir commented 2 years ago

Causes https://github.com/graphql/vscode-graphql/issues/380