Add directive highlighting for type system directives

graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)

https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql

MIT License

557 stars 71 forks source link

Add directive highlighting for type system directives #326

Closed markusjwetzel closed 2 years ago

markusjwetzel commented 3 years ago

GraphQL directives can be added to many places: https://spec.graphql.org/draft/#sec-Type-System.Directives

Currently not all places listed in the spec are supported for syntax highlighting. Especially many type system directive locations are missing. This pull request adds the missing places to the grammar, so that directives are syntax highlighted on all possible places.

Potentially this also fixes issue graphql/graphiql#2300.

linux-foundation-easycla[bot] commented 3 years ago

The committers are authorized under a signed CLA.

:white_check_mark: Markus J. Wetzel (f59e5267dc57908a357d737c20bf7989bbe4e5cc)

acao commented 3 years ago

Awesome, thanks! Are you able to sign the CLA?

acao commented 2 years ago

@markusjwetzel when you sign the CLA we can release this!

markusjwetzel commented 2 years ago

@acao Sorry for late reply. It's now signed. :)

acao commented 2 years ago

great, about to release this one tonight!