search

grappler / polylang-slug

A unique post slug within the language in Polylang. This allows for a page to have same/identical slug in multiple languages.
268 stars 84 forks source link

Wordpress dependency #22

Closed JorisM closed 8 years ago

JorisM commented 8 years ago

Is it really required to have wordpress as a dependency?

https://github.com/grappler/polylang-slug/blob/master/composer.json#L20

This causes two folders with wordpress installed in our case. As a workaround we currently ignore the wordpress folder added through polylang-slug.

grappler commented 8 years ago

So, you don't load WordPress using composer?

JorisM commented 8 years ago

we use wp-cli to install it to a custom location.

thanks for your time, i appreciate it. gruess us winterthur :)

grappler commented 8 years ago

What are the pros for using wp-cli instead of composer? Have you tried defining wordpress-install-dir for your custom location.

    "extra"       : {
        "wordpress-install-dir": "wp",
        "installer-paths": {
            "content/mu-plugins/{$name}/" : ["type:wordpress-muplugin"],
            "content/plugins/{$name}/"    : ["type:wordpress-plugin"],
            "content/themes/{$name}/"     : ["type:wordpress-theme"]
        }
    }

@swissspidy What do you think?

swissspidy commented 8 years ago

@grappler Why me? :-)

The package is of type wordpress-plugin, so the dependency should already be clear. Most packages don't have that dependency. Some wouldn't even add the Polylang dependency. Perhaps we as developers are flexible on this.

Mixing composer with wp-cli is rather uncommon though.

lwe commented 8 years ago

Hey @grappler et all, hope you guys don't mind if jump in, but I'm working together with @JorisM on that project. The thing is that in our case the WordPress instance is managed externally and we only used composer.json to fetch a few plugins. So this indeed maybe a bit of a unique setup :smile:

grappler commented 8 years ago

Ok, that makes sense. Just wanted to understand the reasons behind it better. :smile:

FYI - There is a monthly WordPress meetup in Bern. http://www.meetup.com/WordPress-Bern/

Thanks @swissspidy for your feedback :smile:

lwe commented 8 years ago

:tada: thanks a lot for the quick response and fix!

Cool, good to know regarding the WP Meetup :+1:

JorisM commented 8 years ago

alright thanks!

swissspidy commented 8 years ago

Don't forget the Zurich meetup ;) And WordCamp Switzerland — happening again this year!