search

graspit-simulator / graspit

The GraspIt! simulator
http://graspit-simulator.github.io/
Other
180 stars 81 forks source link

break apart contact.h/.cpp #48

Closed jvarley closed 8 years ago

jvarley commented 8 years ago

contact.cpp was ~1800 lines. I prefer to have a h/cpp for each subclass, especially for something so integral to graspit. I think breaking this file up improves readability.

I made no other changes besides teasing apart the classes to their own individual files.

jvarley commented 8 years ago

@mateiciocarlie @JenniferBuehler

Any thoughts on this. I am planning on doing the same thing with body.h/.cpp at some point.

mateiciocarlie commented 8 years ago

Looks great to me!

JenniferBuehler commented 8 years ago

This is great, I noticed that as well before and was wondering why it's all in one, so this was a good improvement.