Fix the "Lint code base" workflow and package.json

[ptgott]

Fix the "Lint code base" workflow and package.json

This change cleans up the "Lint code base" GitHub Actions workflow in order to ensure that it works as expected:

• Change node-version to 18 to match Vercel as well as the gravitational/teleport GitHub Actions runner.
• Build the docs to add an extra layer of protection against faulty docs changes making it to Vercel
• Remove cacheing logic. gravitational/docs PRs aren't frequent enough to warrant a cache for node_modules and yarn state, and often need to change dependencies anyway. Removing this takes away unneeded complexity. Also worth noting that the cacheing logic referred to an nvm step that isn't executed in this job.

This change also fixes the "engines" key in package.json. This was previously given as "engine", which is not a valid package.json key. Also constrains the Node version to minor/patch releases of v18.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 15, 2023 9:31pm

[ptgott]

Worth noting that the PR that ended up breaking Vercel deploys (https://github.com/gravitational/docs/pull/367) actually passed the Vercel deployment step. I'm still not sure why this is. Hopefully adding yarn update-and-build to the GHA workflow for gravitational/docs PRs will prevent stuff like this.

I've confirmed that cherry-picking #367 on to this branch fails the linter and yarn typecheck locally.

[ptgott]

@avatus Currently the base.yml job runs on push. If we want it to build the docs site (which takes >10mins), should I change that to pull_request and push with the main branch so the GHA runner doesn't run as much?

[avatus]

I think on pr and push sounds fine to me. Wow, how did we miss the engines thing lol. Thanks!

[ptgott]

@avatus Thanks! Just tweaked the on settings