search

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.38k stars 1.74k forks source link

Allow Teleport license expiry warnings to be shown to admins only #28909

Open webvictim opened 1 year ago

webvictim commented 1 year ago

Currently, Teleport license expiry warnings are alerts logged at level HIGH 90 days before a license expires. This means that they appear to all users in the web UI and tsh output and cannot be acknowledged - see https://github.com/gravitational/teleport/issues/17188#issuecomment-1282771994 for more details.

The warnings can be "snoozed" daily until 7 days prior to expiry as per https://github.com/gravitational/teleport/blob/e91dba7eccb5887573d11bc0fe914cd9dfada8db/rfd/0084-license-expiration-warnings.md - but this does not satisfy the request.

It's undesirable for these warnings to be shown to cluster end users who aren't able to do anything to action them - it's likely to lead to confusion. We should provide a way to only have license expiry warnings shown to cluster administrators.

stevenGravy commented 1 year ago

perhaps this should only occur for roles that have specific resources listed.

TeleLos commented 1 year ago

Renewed interest in this improvement. Ticket 8095.

Tener commented 8 months ago

More interested parties. Ticket 9701.

yair-segal commented 7 months ago

We just had an intro-demo today to the organization, and the first comment from an end user was "why am seeing that my license is about to expire?". Indeed -- this banner unnecessarily confuses users, and is not relevant to them.

yair-segal commented 6 months ago

Until resolved, perhaps the License expiration warn message can be rephrased. All users see: “Your Teleport Enterprise Edition license will expire …” and they think it’s something personal with their user (because of the “Your”)— and they all reach to for clarifications. A more generic message (e.g. replace “Your” with something else) can improve the user experience….