Sanity checks for releases

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.

https://goteleport.com

GNU Affero General Public License v3.0

17.49k stars 1.75k forks source link

Sanity checks for releases #4857

Open webvictim opened 3 years ago

webvictim commented 3 years ago

We could do with some Makefile targets (or maybe Git hooks) to validate that:

If we push a commit with a name Release x.y.z that the Makefile actually contains VERSION=x.y.z and not some other version
If we push a vx.y.z Git tag, the Makefile in that commit actually contains VERSION=x.y.z
- it should fail to push if not
If Drone starts processing a tag, it should fail out early with a warning if the VERSION and tag do not match (as it will fail to build artifacts)

codingllama commented 2 weeks ago

Reproducing here a few asks from #13983:

What would you like Teleport to do?

Replace various manual binary checks with automation, including but not limited to:

List of dynamic dependencies
Required glibc version
Presence of (static) libfido2 for tsh (Linux and macOS)
Presence of Touch ID for tsh (macOS)

As an extra for this feature request, we should exercise delivery pipelines in regular builds, to make sure they are in good shape and produce binaries that pass the criteria above.