search

gravitl / netmaker

Netmaker makes networks with WireGuard. Netmaker automates fast, secure, and distributed virtual networks.
https://netmaker.io
Other
9.4k stars 547 forks source link

client can not join a network when the apiconnstring is http and IP address #1110

Closed imwower closed 2 years ago

imwower commented 2 years ago

https://github.com/gravitl/netmaker/blob/c147cc2eb92b1b3e419b0640ce4025d8ae0b1d2d/netclient/functions/join.go#L122

url shoud be: url := cfg.Server.API + "/api/nodes/" + cfg.Network

without the "https://" prefix

afeiszli commented 2 years ago

What is your use case for running over http? Running server with http is highly discouraged and insecure.

afeiszli commented 2 years ago

Closing. HTTP should not be used for server.