gravitl / netmaker

Netmaker makes networks with WireGuard. Netmaker automates fast, secure, and distributed virtual networks.
https://netmaker.io
Other
9.4k stars 547 forks source link

[Bug]: Renaming an external client causes the private key to be replaced with `[ENTER PRIVATE KEY]` #2125

Closed Southpaw1496 closed 1 year ago

Southpaw1496 commented 1 year ago

Contact Details

paw@southpaw1496.me

What happened?

When I created an External Client in Netmaker, I renamed it and downloaded the config, which was this:

[Interface]
Address = 10.1.2.254/32
PrivateKey = [ENTER PRIVATE KEY]
MTU = 1420

[Peer]
PublicKey = SiBG2LkQabUhgxGoLPMXSSenyc3CyJriFVgrrkaeMQI=
AllowedIPs = 10.1.2.0/24
Endpoint = REDACTED
PersistentKeepalive = 20

As you can see, where the private key should be there is instead "[Enter Private Key Here]". After some testing, I found that this only occurs if you rename the external client, and generates correctly if you leave the name as default.

Version

Not listed

What OS are you using?

Linux

Relevant log output

[netmaker] 2023-03-16 21:25:51 southpaw created new ext client on network netmaker`

Contributing guidelines

afeiszli commented 1 year ago

added to backlog