Name of `castle_type=palace` are not displayed (or displayed only at high zoom level)

nachanon commented 5 years ago

I have been retagging few important non-tourism palace POIs in inner Bangkok area on OSM as historic=castle, castle_type=palace to indicate what they actually are. These are way-type POIs with relatively large area. Soon enough; I found out that while OSM Mapnik/Carto do render them, these POIs' name ended up not displaying properly, i.e. not displaying at all (except under very high zoom levels in some cases).

This problem make these POIs very difficult to find on OSM, despite their size and importance (both historical and as general orientation points).

Please investigate and fix.

Expected Behavior

Palace name should be displayed when its icon appears and its rendered area size could accomodate both icon and text.

Actual Behavior

Palace name is only displayed when zoom level is 16 or greater, regardless of its rendered size (and sometimes not displayed at all, for an unclear reason).

Examples

Note that each screenshot also links to the OSM view in question...

Chitralada Palace (historic=castle, castle_type=palace), which is well known as a residence and workplace of the late HM Bhumibol Mahidol, and also a current residence of queen mother Sirikit Mahidol.

On OSM Carto, the palace's name is not displayed until zoom level is 16 or greater- despite the fact that some lower levels got enough space to display the text.
- Zoom level 15 (name not displayed, in spite of the space):
- Zoom level 16 (the palace is very large on the screen, but it is actually the lowest zoom level that the name displays):
Sa Pathum Palace (historic=castle, castle_type=palace, leisure=garden, access=private) which is well known as a residence of HRH Sirindhorn Mahidol.

On OSM Carto, the palace's name is not displayed in any zoom level. (Only icon is displayed) Also, the object has also gone through several intentional mistagging attempts, because OSM Carto does not render it when tagged properly.
- Zoom level 17 (name not displayed, in spite of the space):
- Zoom level 19 (maximum zoom; name still not displayed, even when the palace already filled most of the screen):

System Information

Mapnik/Carto instance: openstreetmap.org
Browser: Pale Moon 25.8.1 (GNU/Linux 32-bit)

matkoniecz commented 5 years ago

https://www.openstreetmap.org/way/37910308

I am not exactly sure what went wrong here but I would reconsider tagging wall, garden and palace as a single object.

jeisenbe commented 5 years ago

The current code is set to display historic=castle + castle_type=palace icons (the symbol) at z15 and the name text at z16.

We could move the text label of the palace name to z15 for large palaces, in theory.

jeisenbe commented 4 years ago

@nachanon are you interested in submitting a PR to address this issue by showing the name label at z15 as mentioned above?

gravitystorm / openstreetmap-carto