search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.51k stars 811 forks source link

Remove rendering of shop=jewellery (but keep jewelry) #4962

Open HolgerJeromin opened 2 months ago

HolgerJeromin commented 2 months ago

https://wiki.openstreetmap.org/wiki/Tag:shop%3Djewellery has been deprecated but the single existing node in the osm database is still rendered:

https://www.openstreetmap.org/node/10798568929

image

I have no rendering stack available, so I could only do a blind fix.

Ref deprecation in iD editor since 2019: https://github.com/openstreetmap/iD/pull/6266

imagico commented 2 months ago

In general i am wary about removing support for tags that have gone out of use due to mechanical edits (and potentially subsequent suppression of continued use by self appointed tagging police).

In this case, however - while the reduction to almost zero use is largely due to a mechanical edit in late 2022 - the tag has never had wide adoption in the first place with peak use in 2018 being around 350 while the competing tag back then had already about 100 times as much use. Hence i would be in support of removing this .

pnorman commented 1 month ago

I'm fine with how it was removed from the DB so it should removed. This is a good first issue - anyone picking it up just be search to search the code for all occurrences of jewellery