gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.51k stars 811 forks source link

render leisure=bathing_place #4976

Open perericr opened 4 weeks ago

perericr commented 4 weeks ago

leisure=bathing_place is the currently official tag (https://wiki.openstreetmap.org/wiki/Swimming_and_bathing) for basic bathing places in natural bodies of water. This is a common feature in the Nordic countries, and a popular location in summer months.

It would be helpful having such tag rendered in carto.

suggested rendering

Similar to amenity=public_path, which is also quite similar to the Swedish road sign for such facilities: https://commons.wikimedia.org/wiki/Road_signs_in_Sweden#/media/File:Sweden_road_sign_H15.svg

HolgerJeromin commented 4 weeks ago

Thanks for your suggestion. ref https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dbathing_place Has 260 ways and 1100 nodes right now in the osm database.

imagico commented 4 weeks ago

Current situation w.r.t. various tags for swimming/bathing related features:

My concern is - apart from the low and geographically narrow use so far - that the tag is documented very vaguely. It does not make a distinction between swimming and bathing (making it difficult to visualize and limiting usefulness for map users) and deliberately does not clearly delineate its use towards other more common tags (amenity=public_bath, leisure=swimming_area).

That does not disqualify the tag from being shown in OSM-Carto IMO - but we would need to rework existing rendering as described above to more clearly distinguish different meanings and provide more specific feedback and we would need to look into interpreting secondary tags to provide a more meaningful classification (leisure=bathing_place + sport=swimming has currently 133 uses, there does not seem to be established tagging for officially designated and water quality checked places so far).

See also #844, #4620.

perericr commented 4 weeks ago

Thanks for your comments. I can understand the concern regarding difference between bathing and swimming; however, I would say the tag covers a quite specific type of facility - which however in most cases can be used for both bathing and swimming. A bathing-like icon would probably be safe, as that's what the main usage is, even if sportive swimming is often possible.

The delineation "upwards" do have (as stated in the wiki) corner cases, but there are many facilities that are unambiguously covered. I am (as a mapper) mostly glad that the international OSM community seems to have found a tagging scheme for outdoor bathing that includes this kind of place - we had many discussions on the Swedish mailing list before this tagging emerged on how to map it properly.

imagico commented 4 weeks ago

however, I would say the tag covers a quite specific type of facility

This is not really a subject for discussion here - but if that is indeed the case then it would be highly advisable to change the documentation on the wiki to reflect that. So far the tag is used predominantly in Sweden and that use could well comply by a narrow definition locally - but if it gets adopted more broadly elsewhere based on what is written on the wiki you could well end up with leisure=bathing_place becoming essentially an umbrella tag for leisure=beach_resort, amenity=public_bath and any other places where people go into the water for recreational purposes. And as such we would probably not want to render it here since more specific tags exist and are in broad use.