search

graycoreio / daffodil

Angular Ecommerce PWA Framework
https://next.daff.io
MIT License
156 stars 31 forks source link

[OTHER] Move `@daffodil/design` component examples to its own `@daffodil/design-examples` package #1235

Open griest024 opened 3 years ago

griest024 commented 3 years ago

Also remove declarations and entry components from design-land

xelaint commented 3 years ago

@griest024 Can you provide more details on this issue? Where will the example modules go?

griest024 commented 3 years ago

@damienwebdev can confirm but I believe that with Angular 10, those modules are now unecessary and can be removed entirely.

griest024 commented 3 years ago

I think this is because entryComponents is no longer necessary

damienwebdev commented 3 years ago

There are some aspects of the example modules that can be removed. I'm not entirely sure what is required by @angular/elements and their respective modules. I know for certain that now, with Ivy, the entryComponents can be entirely deleted.

damienwebdev commented 9 months ago

These examples should instead be in a new package called @daffodil/design-examples.