search

grblHAL / Plugin_keypad

grblHAL keypad plugin
Other
7 stars 6 forks source link

Problem enabling macros #10

Closed pimsierhuis closed 6 months ago

pimsierhuis commented 6 months ago

I'm trying to enable macros but am puzzled by the following issue. I use picocnc board with rp2040 and use the web builder to create firmware. When I use "MACROS_ENABLE=3", the keypad (over serial) works, but $490 gives an error:53 (probably due to AUX input pin shortage). But when I use "MACROS_ENABLE=2" (the way I want to use it), the control-connection over USB stops working! I've looked at macros.c but can't find any explanation.

Help would be very welcome!

pimsierhuis commented 6 months ago

Web Builder json-files attached:

macro_onlykeypad.json macro_auxandkeypad.json

terjeio commented 6 months ago

Seems it is due to a memory leak - can you try again now?

pimsierhuis commented 6 months ago

It works now. Great, thanks!

For my understanding: memory leak where? In the web builder?

terjeio commented 6 months ago

In the macro plugin, bad code on my part. Will commit fix later.

pimsierhuis commented 6 months ago

OK, check. Thanks for the quick fix!