search

greedyj4ck / DEGENESIS-FoundryVTT

DEGENESIS: Rebirth system for Foundry Virtual Tabletop
26 stars 22 forks source link

Ammo load in magazine starts at 0 and cannot be loaded #66

Closed mhiner closed 9 months ago

mhiner commented 2 years ago

When a ranged weapon is assigned to an actor with appropriate ammunition in their inventory the weapon reads "0/<capacity" e.g. "0/5". When an attack is made the first number is decremented leading to negative values. e.g. "-1/5"

greedyj4ck commented 2 years ago

Will investigate :)

greedyj4ck commented 2 years ago

Thinking about solving this one - I can create conditional preventing users from attacking with range weapon without any ammunition in magazine.

mhiner commented 2 years ago

I am not sure if that will solve it alone. I may have been doing something wrong but I could not get the gun to load ammunition from inventory. I tried 5.56 and lead bullet both on a marvel, in the case of the 5.56 I modified the weapon directly rather than using a modification.

It would help with the negative numbers but not the fact that I could not get it to be positive either. (I grant this may be user error)

greedyj4ck commented 2 years ago

Maybe there is something wrong with the items itself. Will check it out. Working fine on my side (at least partially) reload

greedyj4ck commented 2 years ago

Just tested Marvel with Lead Bullets, working fine. What version are you on?

mhiner commented 2 years ago

Disregard, it must have been operator error. I just tried again and it works.

greedyj4ck commented 2 years ago

Np. Still will add a soft lock preventing user attacking without ammo (toggleable from options). Closing issue for now :)

Dentatum commented 11 months ago

Sorry for necromancy, but I'm having this same error as well imagen

greedyj4ck commented 11 months ago

Sorry for necromancy, but I'm having this same error as well imagen

Sorry to hear that. I need more information like the system version and steps to reproduce the issue. I never managed to reproduce it on my side.

Dentatum commented 11 months ago

Sure! Foundry 11.315 - Degenesis 0.6.1.2

www_screencapture_com_2023-11-15_19_48.webm The system automatically substracts 1 ammo from the magazine when clicking the distance to roll the attack, no matter the current one in the magazine.

Happens with any distance option on shooting.

greedyj4ck commented 11 months ago

Thanks, I will look into the bug and release a fix with a next milestone.

greedyj4ck commented 9 months ago

Fixed.

Release planned for 0.6.2.