search

greenbone / openvas-smb

SMB module for OpenVAS Scanner
GNU General Public License v2.0
47 stars 47 forks source link

Fix pkgconfig for gnutls #30

Closed tuxmaster5000 closed 3 years ago

tuxmaster5000 commented 3 years ago

Fix https://github.com/greenbone/openvas-smb/issues/29

jjnicola commented 3 years ago

Hi @tuxmaster5000, Does it work for you? It does not pass the CI tests. I have tested this PR in my local dev environment and it is broken as well.

tuxmaster5000 commented 3 years ago

Yes,it will work on my side, but I use CentOS as the build OS. Can you modify the test, so that the whole compile call are visible? On my build at that stage there is no '-R' option used:

[ 91%] Linking C executable winexe
cd /builddir/build/BUILD/openvas-smb-1.0.5/winexe && /usr/bin/cmake3 -E cmake_link_script CMakeFiles/winexe.dir/link.txt --verbose=1
/usr/lib64/ccache/cc -Wno-unused-result -fno-strict-aliasing -fPIC -O2 -D_FORTIFY_SOURCE=2 -fstack-protector -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1  -m64 -mtune=generic  -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -rdynamic CMakeFiles/winexe.dir/winexe.c.o CMakeFiles/winexe.dir/service.c.o CMakeFiles/winexe.dir/async.c.o CMakeFiles/winexe.dir/winexesvc_exe.c.o  -o winexe  ../samba/libsamba-static.a -ldl -lgnutls -lpopt -Wl,-z,relro -Wl,-z,now -L/usr/lib64/heimdal -lkrb5 -lgssapi -lasn1 -lcom_err -pthread -L/usr/lib64/gvm-helper -lgnutls -ltspi -latomic -lhogweed -lgmp -ltasn1 -lidn2 -lunistring -lnettle -lhdb
jjnicola commented 3 years ago

We will update the image used for running the tests, as it is currently based on stretch, but it should be buster. It finally worked in my local env, I just was missing a dependency for gnutls version I have installed in my Debian. I have not seen the "-R" issue either.

jjnicola commented 3 years ago

Hi @tuxmaster5000,

could you add Changlog entry? after your commit, the test will run again, using the new docker images. This time, all check should pass without problems.

You can check the Changelog format here

tuxmaster5000 commented 3 years ago

Now the change log entry was added.