greenelab / connectivity-search-frontend

Frontend code for connectivity search (formerly "Hetmech")
https://het.io/search
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Nodes without a URL still hyperlink the source field #162

Closed dhimmel closed 4 years ago

dhimmel commented 4 years ago

From https://het.io/search/?source=26663&target=14379

image

For the "source" field of the target node, the hyperlink for "Reactome via Pathway Commons" is empty:

<div class="info_table_value small left"><div tabindex="0" class="dynamic_field " data-expanded="false"><a class="nowrap" href="">Reactome via Pathway Commons</a></div></div>

This is because the API does not return a URL:

{
    "id": 14379,
    "identifier": "PC7_6055",
    "identifier_type": "str",
    "name": "Orexin and neuropeptides FF and QRFP bind to their respective receptors",
    "properties": {
        "source": "Reactome via Pathway Commons",
        "license": "CC BY 4.0"
    },
    "metanode": "Pathway"
}

I'm thinking in these cases we should just not show any hyperlink rather than a blank one (which in my browser ends up going to the current address).

vincerubinetti commented 4 years ago

Sorry, didn't realize you had reported this several months before Casey mentioned it to me! This was closed with #163