PLANET-4334 Allow a list of non-P4 urls not to have the ↗️ icon

greenpeace / planet4

Built on top of Wordpress tech, Greenpeace Planet 4 powers digital platforms to engage with millions and win campaigns around the world.

https://planet4.greenpeace.org

Creative Commons Attribution Share Alike 4.0 International

67 stars 27 forks source link

PLANET-4334 Allow a list of non-P4 urls not to have the ↗️ icon #174

Open planet-4 opened 3 years ago

planet-4 commented 3 years ago

We add an external icon on links that point to an external domain. As a follow up we should not display the external link icon for some links we use regularly for engagement opportunities (eg. act.greenpeace.org).

Requirements

Add a new field "Commonly used external domains" under Planet 4 > Social.
Use a textaea field to hold multiple domains.
Help text: "Links for these domains will not open in a new tab and will hide the external link icon."
Both title and description should be translatable.
Adjust external link behaviour to remove external link icon and opening in a new tab for these domains.

Reporter: ltiralon
Sections: Styling/Theme

oekeur commented 2 years ago

Hi friends 🤗

Sure this won't interfere in a weird way if it's implemented like this? The pre-connect domains are a technical solution for pre-connecting certain assets. If we piggyback on this by refactoring it to "Preferred external domains", that would mean that certain third party domains unintentionally might also lack the external link icon.. I know it's a bit of a edge case, but just to be sure. :)

comzeradd commented 2 years ago

Yeah, we discussed this also in the team. It may make more sense to have an explicit configuration option for this. I'll update the description requirements.

oekeur commented 2 years ago

So what shall we do for this? :) A separate option for the 'domains without link icon'?

comzeradd commented 2 years ago

Description updated. Let's add a new configuration option for this.

oekeur commented 2 years ago

You can assign this one to me :)

suzi-greenpeace commented 2 years ago

thanks Oscar!

On Tue, Apr 12, 2022 at 8:28 AM OscarKeur @.***> wrote:

You can assign this one to me :)

— Reply to this email directly, view it on GitHub https://github.com/greenpeace/planet4/issues/174#issuecomment-1096803360, or unsubscribe https://github.com/notifications/unsubscribe-auth/APR5PAWU2R4LWHBKYBNEF5LVEWCAZANCNFSM5FCAB6LA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- suzi grishpul Interim Head of Engagement Systems *& *Planet 4 Product Manager, Greenpeace International pronouns: they/them/theirs location: Denver, CO, USA (GMT/UTC-6)

Book some time with me https://calendly.com/suzi-grishpul/meet

oekeur commented 2 years ago

Whoops, sorry, this one fell off my radar!: Starting -now really- on it now