search

greentfrapp / lucent

Lucid library adapted for PyTorch
Apache License 2.0
597 stars 89 forks source link

When could Lucent support Neuron Groups? #7

Open RayleighChen opened 4 years ago

RayleighChen commented 4 years ago

The _neurongroups method is mentioned in Building Blocks Notebooks. Lucid also implements this method. Compared to the current version of lucent, the main difference seems to be the direction function in the Objective class. Does Lucent have plans to implement this method? Thanks for your work.

greentfrapp commented 4 years ago

Hi @RayleighChen thank you for your interest in Lucent and PyTorch!

As of 10 seconds ago, the direction and direction_neuron objectives have been added to Lucent thanks to @ndey96!

I had intended to reproduce the Building Blocks notebook a while ago, but I was thinking about whether we wanted the svelte components in Lucent or just import them from Lucid in the notebook. Then other stuff caught up and I'm sorry to say I forgot about it. Since you asked and now we have direction objectives, I might look into it again but no promises!

(Note: for the svelte components, I think we should just do an import from lucid.scratch.web.svelte in the colab rather than copying them over into Lucent, since they don't seem to have dependencies on tf)

Let me know if you would like to help reproduce the notebook, contributions are always welcome!

RayleighChen commented 4 years ago

Hi, @greentfrapp thank you for your reply. In my opinion, the core of the reproduction in the PyTorch version is the consistency of the performance, not the svelte components. Regarding the neuron_groups method, let me try it first.