greeny / SatisfactoryTools

Satisfactory Tools for planning and building the perfect base.
https://www.satisfactorytools.com/
Other
364 stars 80 forks source link

Redirect the root page to 1.0 by default rather than 0.8 #177

Closed dmathieu closed 3 days ago

dmathieu commented 3 days ago

When loading the root page (for example, if you're visiting from a search engine), the app redirects to the 0.8 version, which then shows a modal recommending to switch to 1.0. Most folks are probably running on 1.0 rather than 0.8. So requiring an additional click like this seems pointless.

This change will redirect from root to 1.0 instead.

greeny commented 3 days ago

This is intentional to keep old links leading to 0.8, especially share links, but also codex and other links.

dmathieu commented 3 days ago

Do you have a deprecation/phase out plan? Because 1.0 is still new, but still relying on 0.8 is probably already used by a very small percentage of players. While I get the need to keep things working, that's probably not required forever.

greeny commented 3 days ago

the main problem is share links - if you load a share link, it doesn't have info of which version it uses. So it is just loaded on currently opened version, which can break things (non-existing items, recipes, etc.), as well as show different production (since it gets recalculated once opened).

This is obviously not ideal, but it's caused by a lot of non-ideal decisions taken in earlier phases of development and at this point it's basically technical debt.

However since I'm working on new Tools from scratch (still far from complete), my plan for current Tools is to kinda keep it in the state it is in and deprecate it completely once new Tools are ready. Which is also why the version support was kinda botched in, as it is supposed to be a temporary solution until new Tools are out.

dmathieu commented 3 days ago

That makes sense, thanks.