search

greg0ire / git_template

Automating your workflow with git
http://git-template.readthedocs.org/
GNU General Public License v3.0
227 stars 38 forks source link

Add in Jira/Ticket reference to commit-msg #51

Closed davidcollom closed 6 years ago

davidcollom commented 7 years ago

Add in commit-msg style hooks along with a jira/ticket reference hook

greg0ire commented 7 years ago

Looks great!

Can you make it more generic though? Like, not tied to jira? And please add some documentation describing what this does.

greg0ire commented 7 years ago

Also, what happens/should happen when you have several commits on the branch?

davidcollom commented 7 years ago

Hey, I've squashed my commits and removed references of Jira into a ticketrefplugin.

The expected behavior of this plugin is to prefix the commit message with the ticket reference from the branch name to ensure that the correlation of commit's against a specific feature/ticket/incident/issue etc.

greg0ire commented 6 years ago

cc @juliendufresne :P

Edo78 commented 6 years ago

This looks interesting for my use case. Any chance it could be updated and accepted?

greg0ire commented 6 years ago

@Edo78 sure! You can make your own PR and address the issues, I will merge it!

Edo78 commented 6 years ago

I feel a bit uneasy at copying the code of @davidcollom If he could give me his permission I'll be glad to do it

davidcollom commented 6 years ago

Hey, really sorry I completely forgot about the PR.

I may have some time today to update the PR based off the comments above, I don't see them taking much time.

davidcollom commented 6 years ago

@Edo78 / @greg0ire - I've updated this PR based off the comments you left prior

I added some additional configuration for this hook to support both requirements (Pre/Post reference locations).