search

gregnb / mui-datatables

Datatables for React using Material-UI
MIT License
2.7k stars 931 forks source link

BUG : Expand (KeyboardArrowRight ) icon read as "Unlabelled zero button" by NVDA/JAWS tools. #1699

Open neenu-mathew opened 3 years ago

neenu-mathew commented 3 years ago

Expand (KeyboardArrowRight ) icon in the table read as "Unlabelled zero button" by NVDA/JAWS tools. image

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Your Environment

Tech Version
Material-UI
MUI-datatables
React
browser
etc
neenu-mathew commented 3 years ago

@wdh2100 , @tylerg-smt i have found out the fix for the bug. But not able to create PR in the mui-datatable repo, because of inadequate permissions.

fix :

`<IconButton

      aria-label="expand arrow button"  //new line added for bug fix
      onClick={onExpand}
      style={{ padding: 0 }}
      disabled={expandableRowsHeader === false}
      className={buttonClass}>
      <KeyboardArrowRightIcon id="expandable-button" className={iconClass} />
    </IconButton>`

https://github.com/gregnb/mui-datatables/blob/7558e7393b6ee4b21c9481613429efcdbe7a6ddc/src/components/ExpandButton.js#L28